search

Fr3dMer / softeng_module

0 stars 1 forks source link

51 add docstrings #60

Closed AmyGrimwood closed 8 months ago

AmyGrimwood commented 9 months ago

Please highlight any PEP8 issues you see

AbiHaddon commented 9 months ago

@AmyGrimwood - Message from Freddie regarding line length 'I've interpreted it as any white space before a char is counted (like " 5" is length 5) and anything after a char is not counted (like "5 " is length 1)' - so we are all on the same page

AmyGrimwood commented 9 months ago

As Abi's mentioned, a few lines over 79 but docstrings look good. Need to add logging at some point as well but can leave that for another branch

Am I meant to be adding logging or does that come under Abi's logging tasks?

AbiHaddon commented 9 months ago

As Abi's mentioned, a few lines over 79 but docstrings look good. Need to add logging at some point as well but can leave that for another branch

Am I meant to be adding logging or does that come under Abi's logging tasks?

I don't we ever specified whether I would add logging to the rest of the code. Freddie has added logging to his code and I added logging to the rest of mine. I currently working on #54.