php 7.2 compatibility - Githubissues

FrDeamon / EnseparHtml2pdfBundle

Html2pdf for Symfony 2 as a service.

MIT License

22 stars 22 forks source link

php 7.2 compatibility #30

Closed LeJeanbono closed 6 years ago

LeJeanbono commented 6 years ago

Got this error : Warning: count(): Parameter must be an array or an object that implements Countable Corrected in V5 of html2pdf, see :

https://github.com/spipu/html2pdf/issues/287
https://github.com/spipu/html2pdf/releases/tag/v5.1.0

OwlyCode commented 6 years ago

Hello,

Thanks for the PR ! I noticed that htmlpdf drops support of php 5.3 in the 5.x versions so I can't tag this as a 3.0.1. I'll create the 4.0.0 instead to prevent any bug for users still using php 5.3.

Also the testsuite is outdated, I'll have a look at it.