FrDeamon / EnseparHtml2pdfBundle

Html2pdf for Symfony 2 as a service.
MIT License
22 stars 22 forks source link

Split symfony/symfony dependency #32

Closed Taluu closed 5 years ago

Taluu commented 5 years ago

So that we really need the bare minimum to make it run, without having to include the whole symfony/symfony dependency.

I chose to support only currently supported versions (cf http://symfony.com/roadmap).

I also put PSR-4 instead of (deprecated...) PSR-0.

olix21 commented 5 years ago

duplicate https://github.com/OwlyCode/EnseparHtml2pdfBundle/pull/34

Taluu commented 5 years ago

Thansk for the waking up. I also removed unsupported versions of PHP (well, tests on them actually), same with symfony (as the 2.7 is officially dead).

Maybe the tests should also test on 2.8 though, but... oh well. :D

OwlyCode commented 5 years ago

Hey, thanks for coming back!

Concerning the version drop, I agree that 2.8 and 2.7 should be gone by now on this project. But we need to separate this into an other issue/PR.

Symfony 3.4 still has a long time to live (around mid 2020) and allows php down to 5.5.9 (see https://packagist.org/packages/symfony/symfony#v3.4.28) so we must ensure this library gets tested in 7.0, 5.6 and 5.5. I added a patch here https://github.com/OwlyCode/EnseparHtml2pdfBundle/pull/34#issuecomment-501254072 that shows how we could achieve this.

Taluu commented 5 years ago

Hum, "it should be" still compatible, and I kept 2.8, 3,4.

But for older php version, I think it's fine to "support" it, but testing against them ? I don't really see the point, especially as there's no tests for symfony 3.4 and so on (and phpunit breaks everything anyway).

so it should be "should be supported, but not tested".

OwlyCode commented 5 years ago

We can't call it support if it doesn't get the same quality of service as the newer versions. The other PR I mentioned passes the tests with older php versions so my plan is to merge this PR along the other one so you get both credited as contributors, with SF4 compatibility, tests still running on older php versions + php 7.3 :tada:

Taluu commented 5 years ago

Closing then

OwlyCode commented 5 years ago

Thank you for your time and contribution, this is now into the master!