Allow Symfony v5

[94noni]

Hi @OwlyCode

I plan to use this bundle inside a Symfony v5 app, that is why I opened this PR (draft for now)

Also, do you think we can create a https://github.com/symfony/recipes-contrib ?

TODO:

• create a pre release tag so we can test it
• discuss the recipe creation
  • improve the doc if the recipe is created

Thank you

[94noni]

Friendly ping @OwlyCode

[OwlyCode]

Hello and sorry for the long delay. I've currently very little time to maintain this library. I would even consider giving it away if someone is interested because it deserves better.

This PR is great, could you have a look at why the tests are failing? Thanks!

[94noni]

@OwlyCode thanks for the reply, of course i will have a look at the tests

The bundle is "quite simple" in its job, there is not so much things it deserves more imho that what is already here :) I think just making it Symfony v5 ready is enough, even if not "maintained" anymore

I may ping you back when this PR is finished/ready 👍

[94noni]

@OwlyCode maybe PHP v5.4/v5.5 are no more relevant here? or with an other branch/tag? tests are green otherwise

[Deamon]

Hi, @OwlyCode I'm open to follow your work on the lib if you agree.

Regarding this PR, I agree with @94noni, we should do a new major version and update the composer dependencies.

[OwlyCode]

Hello @Deamon I don't know how I managed that but your message went unnoticed. Are you still ok to take on the lib?

[Deamon]

Hi @OwlyCode, I still agree to take the lib. To be honest, it might moved it to my company's namespace, because I might not be alone to work on it.

Is it fine for you ?

[94noni]

👋🏻 ping @OwlyCode @Deamon :) is there new things related to this PR? Or should I fork myself

Many thanks

[Seb33300]

Hello, any news on this PR? Or any alternative? This is blocking our project to upgrade to Symfony 5.

Failing tests are unrelated. It happens because old PHP version image are no more available to download.

[OwlyCode]

@Deamon I initiated the transfer, you should be able to take over now. Have you got a packagist account so I can add you on it too?

[OwlyCode]

@Deamon I initiated the transfer, you should be able to take over now. Have you got a packagist account so I can add you on it too?

Nevermind, I found you on packagist. Let me know if you are able to migrate the repository from there too.

[Deamon]

@Deamon I initiated the transfer, you should be able to take over now. Have you got a packagist account so I can add you on it too?

Thanks @OwlyCode, I don't know how long it take to be notified for the transfert by Github but I haven't recieved anything yet. I see the package in packagist.

[94noni]

@Deamon will you then merge this PR and tag a new release? thank you

[Deamon]

@OwlyCode I finally received the transfert email, but after the link was expired. Could'd you reiterate the opération ? sorry for the inconvenience.

[94noni]

Closing as I now use an internal/private fork

@Deamon please feel free to report back when you take over this projet/PR for symfony v5 :)

Thank you

[94noni]

Repo at https://github.com/94noni/NoniHtml2pdfBundle

[Deamon]

Well, I thought I would be able to manage this but I havn't seen those few months.

@94noni do you want to take part as a collaborator to this repo ?

[94noni]

@Deamon no i prefer to continue on my repo The readme and composer give explaination and credit to original author Thanks

[Deamon]

I can transfer the ownership to you, would make sense if you continue to work with the bundle.

[94noni]

Hum for now there is nothing more i want/need to add on it For me it is ok to keep like this :)

[Deamon]

Ok, feel free to come back and ask for it if needed.