search

FrSkyRC / ETHOS-Feedback-Community

Feedback & suggestions are welcomed here for ETHOS by FrSky
188 stars 85 forks source link

"inactivity for long time" => "Prolonged inactivity" #3264

Closed packetpilot closed 9 months ago

packetpilot commented 9 months ago

lol, seriously?

Can the pre-baked TTS get some sort of cleanup? If this repo were an actual repo, I'd do it myself, but...

bsongis-frsky commented 9 months ago

What is the problem? The TTS text for all Ethos prompts is included in this repository. You have to follow the wiki.

mawzthefinn commented 9 months ago

It's not a proper english phrase. In fact it's a stereotypical 'Chinglish' sentence.

'Inactivity Alert' or 'Inactive for a long time' would be more correct.

packetpilot commented 9 months ago

I get more than my fair share of Chinglish from my wife, so I do apologize if I hear so much of it that I'm incorrectly attributing that label to this phraseology, which is poor irrespective of which flavor of distortion lens the meaning passes through.

Perhaps my standards need adjusting for a handheld radio's equivalent to what are CAS messages in manned aviation (cabin alert system). Concision is paramount: deliver the point in the fewest number of syllables.

Perhaps I'll fork this and make some tweaks, hopefully not to have a PR declined, but imho "prolonged inactivity" is the "correct" amount of syllables for this message -- I'm still undecided on whether it's the "right" phrase in my mind.

mawzthefinn commented 9 months ago

Prolonged Inactivity is a good phrase, I like that.

packetpilot commented 9 months ago

From this "repository's" readme:

Please keep the GitHub section focused on reporting issues/bugs.

So is your suggestion @bsongis-frsky to

The TTS text for all Ethos prompts is included in this repository. You have to follow the wiki.

...equivalent to FrSky's willingness to accept contributions to the repo other than the context of _mis_use stated in the wiki (and so far as I recall, since the inception of this repo's existence on github)? I was under the impression that this was just for the illusion of some degree of transition to open source development when it clearly never would be.

But perhaps it will be? ...but only to solicit contributions from those whose grammar and lua asphalt can pave over the potholes, or for actual ethos? 🤔

bsongis-frsky commented 9 months ago

It cannot be chinglish as I know only about 2 chinese words ;) I am OK with "Prolonged inactivity", the first post of this issue "lol, seriously" doesn't help to improve my english ;) Now perhaps we could continue in french so that I can laugh myself?

bsongis-frsky commented 9 months ago

Ready for 1.4.17 and next 1.5.0 nightlies