FrSkyRC / ETHOS-Feedback-Community

Feedback & suggestions are welcomed here for ETHOS by FrSky
189 stars 85 forks source link

1.5: Portability issues with new audio scheme #3584

Closed RC-SOAR closed 7 months ago

RC-SOAR commented 7 months ago

Love the features in 1.5, but the new Audio scheme makes model setups less portable - a problem when for 3rd party template creators and people who want to swap setups with others.

This is primarily because of the new 'voices' and - in particular - the voice dependencies in SFs.

People only speak one language, so why not pick up the system files automatically? And while it's nice to have multiple folders for custom sounds, it shouldn't be at the expense of portability - a single 'custom' folder is IMO sufficient for most users.

So two suggestions:

This would remove the need for 'voices', which means the Voice option can be removed from SF's.

The would result in setups which are more portable.

4qr1hu9n7 commented 7 months ago

Works just fine. Please don't change it. Very simple to use.

pstasek commented 7 months ago

Voices have much more potential than just simple change of voice. This is one of the key features for me in 1.5. For example allows me to manage multiple IMAC sequence callings in a single global special function. By selecting a different voice folder I can fly different sequence.

RC-SOAR commented 7 months ago

Voices have much more potential than just simple change of voice.

Okay, point well taken :) I also understand that to change things radically at this stage would not be possible.

Here's another option which would increase portability without impacting existing setups:

So that way template designers could set their custom SF's to 'CustomVoice'. Then instruct users to copy the custom files to the /audio/custom folder.

This would make things simpler for users and template designers (and anyone who wants to share their setup). And there would no impact on existing 1.5 setups.

strgaltdel commented 7 months ago

I had a similar idea, but then I asked myself "and how do you handle language specific custom voices" ?

maybe the English don't want the wav's from a published German template, and the French don't want to hear them from the English template, and.....

so we would end up in another subfolder and we are close to our current "starting position",

That was the point at which I abandoned further considerations

now we have three (language specific) different folder in parallel

my "personal best practise" would be

so a template would get his custom sounds from in the system settings configured folder "user1" whatever the folder is named This would require a "custom sound subfolder" in each lang specific folder AND the definition of this user specific folder in the system settings

i do presume that each user who wants to handle with own, specific and additional sound files will have a motivation to think about the "rules" of the new concept

RC-SOAR commented 7 months ago

"and how do you handle language specific custom voices" ?

The template writer can supply multiple language files in the package as normal.

The user only needs files for one languge, and they can simply copy these into the CustomVoice folder.

audio/UNIVERSAL_CUSTOM

i do presume that each user who wants to handle with own, specific and additional sound files will have a motivation to think about the "rules" of the new concept

Many users will struggle with the new rules, especially those who use canned setups (they use them precisely because they should be easy to configure). This measure is to support those users, and to make it easier for users who want to swap setups.

Also it'll make it easier for template writers, since all SF's can point to 'CustomVoice'.

(No impact on existing 1.5 setups, people can still split up their sound files into voice1, voice2 and voice3 if they wish, bearing in mind that those voice folders only apply to their own device).

mawzthefinn commented 7 months ago

Maybe a Global option, with sounds in the 1.4 location (/Audio)

User can select Global, or Voice 1, 2 & 3 for Play Track. Templates use Global (and this solves some of the custom audio issues users are having in the 1.5 transition, since Global is just the old location)

strgaltdel commented 7 months ago

so we are discussing if a audio/lang/custom

or a audio/custom/(lang?) should be used.

i do undestood the wish to divide between "individual user" = audio/lang

and a "3rd party" / template sources "audio/custom/(lang?)"

structure

what would end in at least one more folder mentioned above

all in all: what would you prefer:

oh, mawz had "quicker fingers", so one more "global" voice..

RC-SOAR commented 7 months ago

so we are discussing if a audio/lang/custom [...]

The extra voice + folder must be independent of lang, and tx. In terms of naming, mawz's suggestion of 'global' instead of 'custom' makes sense. So:

folder = /audio/global, or just /audio
voice = 'voiceGlobal' (system supplied voice)

Typical use case:

  1. Template author places provides custom .wav files (en, it, de etc.) in folders in zip file. Template has Play Audio SF's pointing to 'voiceGlobal'
  2. Template user copies .wav files - for his language only - into /audio/global. No changes necessary to the template or other folders.

The rest of the structure would be as now, no impact on existing setups or other folders. Users can continue using voice1, voice2 etc.

bsongis-frsky commented 7 months ago

I didn't think it would bring so many questions / frustration on forums.

Don't forget that languages are not only a set of audio files, there is a grammar associated to each language. For example in CZ you have 3 forms of plural ...

I would like not to do another change, which will perhaps bring more questions for users who have done it right.

I propose a very simple change in 1.5.2

1) create on all languages a "default" directory. i.e. [en/us, en/gb, en/default], [fr/male, fr/female, fr/default], etc.

2) if the system audio voice1 (main voice) has not already being set, write "default" there, as we are sure that the directory exists

This way with the next update (audio files + firmware), everybody should have audio working

bsongis-frsky commented 7 months ago

Ready for 1.5.2