FrSkyRC / ETHOS-Feedback-Community

Feedback & suggestions are welcomed here for ETHOS by FrSky
187 stars 84 forks source link

(Feature Request). Possible VAR Enhancement. #3955

Open kramgrand opened 4 months ago

kramgrand commented 4 months ago

First off, thanks for all the hard work going into Ethos development and I understand this would be "A nice to have".

When you add values in VARS, you are able to long press the value field and then select a source e.g. Switches, Logic switches, Trims, Analogs, other VARS, Channels etc. Would it / is it possible to add Telemetry to the category list, so that for example different altitudes could be used as a VAR value.

Thank you. Mark

WhiskeyGolf commented 4 months ago

Oh, that's actually a very good idea!

azaz44 commented 4 months ago

I think it doesn't allow telemetry, because VARs are always %. Anything in different units would not work.

I requested an enhancement of this here: https://github.com/FrSkyRC/ETHOS-Feedback-Community/issues/2645

WhiskeyGolf commented 4 months ago

I think it should generally be possible to use Vars with more than just percentages. It should be a blank value without a percent.

Richrfl commented 2 months ago

I fully agree with WG. There is nowhere we can input a number for a calculation, like, for example, to convert % into a decimal number or time into decimal minutes or hours. I would like to have that option to be able to calculate what current street cars call Range, which is the fuel level divided by average consumption. This is important to be able to know how long can you stay in the air until "bing fuel", that is when you get a critical battery warning. I can extend this issue at request for additional explanation if needed.

azaz44 commented 2 months ago

I fully agree with WG. There is nowhere we can input a number for a calculation, like, for example, to convert % into a decimal number or time into decimal minutes or hours. I would like to have that option to be able to calculate what current street cars call Range, which is the fuel level divided by average consumption. This is important to be able to know how long can you stay in the air until "bing fuel", that is when you get a critical battery warning. I can extend this issue at request for additional explanation if needed.

I totally support this feature request, I would love to have more power in vars related to telemetry, as this is something I use a lot.

But I think what you need might be possible already. I select different pack capacities with a var, which is a percentage of 10000mAh (as vars only support percents), and then calculate mAh out of it in calculated telemetry sensors. Then I calculate 'mAh left' (which is 'pack mah' - 'used mah'), and then even convert it to estimated flight time left (in seconds).

But there are some workarounds and things that could be better. For example entering pack capacity in vars as 53 percent for 5300 mAh is a bit ugly. Time is displayed in seconds always, like 150s instead of 2:30 etc.

azaz44 commented 2 months ago

There is nowhere we can input a number for a calculation, like, for example, to convert % into a decimal number or time into decimal minutes or hours.

I would like to have that option to be able to calculate what current street cars call Range, which is the fuel level divided by average consumption

I think you need to check "calculated sensors" in telemetry, it's all there and a lot of fun.

Richrfl commented 2 months ago

Thank you for the idea 44. Should I assume you are using a current sensor to do all the walk-around?

On Tue, Jul 9, 2024 at 2:42 AM azaz44 @.***> wrote:

I fully agree with WG. There is nowhere we can input a number for a calculation, like, for example, to convert % into a decimal number or time into decimal minutes or hours. I would like to have that option to be able to calculate what current street cars call Range, which is the fuel level divided by average consumption. This is important to be able to know how long can you stay in the air until "bing fuel", that is when you get a critical battery warning. I can extend this issue at request for additional explanation if needed.

I totally support this feature request, I would love to have more power in vars related to telemetry, as this is something I use a lot.

But I think what you need might be possible already. I select different pack capacities with a var, which is a percentage of 10000mAh (as vars only support percents), and then calculate mAh out of it in calculated telemetry sensors. Then I calculate 'mAh lest' (which is 'pack mah' - 'used mah'), and then even convert it to estimated flight time left (in seconds).

But there are some workarounds and things that could be better. For example entering pack capacity in vars as 53 percent for 5300 mAh is a bit ugly. Time is displayed in seconds always, like 150s instead of 2:30 etc.

— Reply to this email directly, view it on GitHub https://github.com/FrSkyRC/ETHOS-Feedback-Community/issues/3955#issuecomment-2216708433, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHVFBVQHTAHZPYWJHTPR2LZLOA47AVCNFSM6AAAAABHASNYIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWG4YDQNBTGM . You are receiving this because you commented.Message ID: @.***>

-- Ricardo

Richrfl commented 2 months ago

I did, and part of the idea is to use the calculated sensors, but still, there is no way to enter a number to complete the solution. Also, it is not easy to "trim" your brain on how much time is, for example, 334 seconds.

On Tue, Jul 9, 2024 at 3:08 AM azaz44 @.***> wrote:

There is nowhere we can input a number for a calculation, like, for example, to convert % into a decimal number or time into decimal minutes or hours.

I would like to have that option to be able to calculate what current street cars call Range, which is the fuel level divided by average consumption

I think you need to check "calculated sensors" in telemetry, it's all there and a lot of fun.

— Reply to this email directly, view it on GitHub https://github.com/FrSkyRC/ETHOS-Feedback-Community/issues/3955#issuecomment-2216762803, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHVFBUS2ZHVNH36B3SO46DZLOD57AVCNFSM6AAAAABHASNYIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWG43DEOBQGM . You are receiving this because you commented.Message ID: @.***>

-- Ricardo

azaz44 commented 2 months ago

Thank you for the idea 44. Should I assume you are using a current sensor to do all the walk-around?

I fly helis and current typically comes from ESC telemetry

azaz44 commented 2 months ago

I did, and part of the idea is to use the calculated sensors, but still, there is no way to enter a number to complete the solution. Also, it is not easy to "trim" your brain on how much time is, for example, 334 seconds.

I agree with 334 seconds. I learned to live with that, and the number is mostly important for me at the end of the flight, so it rather is below 60. But yes, improvement would be welcome.

But not sure what do you mean by "not possible to enter a number"?

Richrfl commented 2 months ago

About the number, like entering 60 to convert 340 seconds in minutes. About the current I don't use frisky ESCs and the cost does not justify what I can get in return, specially for a 100A rated esc.

On Tue, Jul 9, 2024, 6:41 PM azaz44 @.***> wrote:

I did, and part of the idea is to use the calculated sensors, but still, there is no way to enter a number to complete the solution. Also, it is not easy to "trim" your brain on how much time is, for example, 334 seconds.

I agree with 334 seconds. I learned to live with that, and the number is mostly important for me at the end of the flight, so it rather is below 60. But yes, improvement would be welcome.

But not sure what do you mean by "not possible to enter a number"?

— Reply to this email directly, view it on GitHub https://github.com/FrSkyRC/ETHOS-Feedback-Community/issues/3955#issuecomment-2218851280, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHVFBSYA6X7VZX5BUY6ZWDZLRRIVAVCNFSM6AAAAABHASNYIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYHA2TCMRYGA . You are receiving this because you commented.Message ID: @.***>

azaz44 commented 2 months ago

About the number, like entering 60 to convert 340 seconds in minutes. About the current I don't use frisky ESCs and the cost does not justify what I can get in return, specially for a 100A rated esc.

In calculated sensors you can do any calculation you want and you can add any numbers there if that's what you mean, not sure if you tried them?

I don't use Frsky rsc either.

Richrfl commented 2 months ago

I like this exchange a lot, 44. You are several steps ahead of me and each time you force me to ask more questions about your experiences. Let's go to the first and probably simplest question. I have been diving into the calculated sensors, and cannot find a way to enter a number. After I select a function, I get the Category list, and that sends me to a the list of the Members of that category, therefore the question is what I am missing that I cannot find a way to enter a number? The second question is about the ESC current data. If this is not a FrSky device, how do you transfer a "foreign" information into the FrSky telemetry? My ESC can provide me current and temperature, but as far as I know only to my cellphone app via WiFi. Can you help me please?

On Wed, Jul 10, 2024 at 1:32 AM azaz44 @.***> wrote:

About the number, like entering 60 to convert 340 seconds in minutes. About the current I don't use frisky ESCs and the cost does not justify what I can get in return, specially for a 100A rated esc.

In calculated sensors you can do any calculation you want and you can add any numbers there if that's what you mean, not sure if you tried them?

I don't use Frsky rsc either.

— Reply to this email directly, view it on GitHub https://github.com/FrSkyRC/ETHOS-Feedback-Community/issues/3955#issuecomment-2219598218, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHVFBWLOGTBTBNNABCR6BLZLTBPTAVCNFSM6AAAAABHASNYIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZGU4TQMRRHA . You are receiving this because you commented.Message ID: @.***>

-- Ricardo

azaz44 commented 2 months ago

I like this exchange a lot, 44. You are several steps ahead of me and each time you force me to ask more questions about your experiences. Let's go to the first and probably simplest question. I have been diving into the calculated sensors, and cannot find a way to enter a number. After I select a function, I get the Category list, and that sends me to a the list of the Members of that category, therefore the question is what I am missing that I cannot find a way to enter a number?

I don't have the radio at hand, but you can see an example here: https://github.com/FrSkyRC/ETHOS-Feedback-Community/issues/4219

There's a calculated sensor, which divides another sensor value by 12 (to get avg. cell voltage of a 12s pack). If you edit your calculations and add a new step there, you might need to "long press" and "convert to value" to enter a value instead of selecting another sensor.

Calculated sensors are very powerful, you can do a lot with them.

The second question is about the ESC current data. If this is not a FrSky device, how do you transfer a "foreign" information into the FrSky telemetry?

I fly helicopters. In helis world ESC transmits telemetry info to the FBL (filght controller), and FBL to FrSky receiver. I never did anything like this without an FBL so I can't help with this.

Richrfl commented 2 months ago

The convert to value was the part that I had not gotten right. You probably solved my walkaround. I will work on it. About the ESC, and the FBL (which I used in fixed wing for the sake of fun) it is clear. Thank you very much for your help.