FrSkyRC / ETHOS-Feedback-Community

Feedback & suggestions are welcomed here for ETHOS by FrSky
191 stars 85 forks source link

Several issues with Calculated Sensor (X18SE, Ethos 1.5.15.EU) #4585

Closed PeterGraz closed 1 month ago

PeterGraz commented 1 month ago

There are several problems when creating a custom Calculated Sensor (German user interface). After selecting the Formula Custom you get the following screen: ScShot1 a large black area up to the next menu item ScShot2 ScShot3 Then I entered the name of the sensor (DEMO) and 2 decimal places and did not change the range ScShot4 I selected the receiver voltage as the source, added a division, selected “Convert to value” and I got the following screen ScShot7 Step size 0? chose a value of 3: Calculation correct ScShot8 then I added the value 431 ScShot10 the value 431 was apparently divided by 100 (2 decimal places?) and the increment? then I added the receiver voltage again ScShot12 Somehow correct result Finally, I replaced the addition with a multiplication ScShot13 ScShot14 Now I'm questioning my primary school education!?

If desired, I can create more funny examples. Best regards, Peter

bsongis-frsky commented 1 month ago

Display issue - The problem is fixed since some time in 1.5.16 :

ScShot1 ScShot2 ScShot3

bsongis-frsky commented 1 month ago

Step badly displayed - The fix is ready for the next nightlies :

ScShot7 ScShot8 ScShot10

PeterGraz commented 1 month ago

Bertrand, merci pour ta réponse rapide! Please pay also attention to the calculation. Is this the desired result? Regards, Peter

bsongis-frsky commented 1 month ago

Multiplication & Division - The decimals are not displayed when a fixed value is used :

image

bsongis-frsky commented 1 month ago

Other operations - The decimals are displayed :

image

bsongis-frsky commented 1 month ago

Parenthesis added when a multiplication follows an addition :

image

image

bsongis-frsky commented 1 month ago

The same sensor, when decimals setup to 1 displayed 108.0V until release 1.5.15. It will now display 10.8V :

image

bsongis-frsky commented 1 month ago

The same sensor will have internal conversions from the calculations unit to the display unit (when possible) :

image

bsongis-frsky commented 1 month ago

Check the multiplication with the previous voltage ....

image

image

PeterGraz commented 1 month ago

Your examples look perfect! Looking forward to 1.5.16, Peter