refactor: renamed UserDto in core project to AbstractBaseUserDto, renamed AppUserDto in subprojects to UserDto

Frachtwerk / essencium-backend

Essencium Backend is a software library built on top of Spring Boot that allows developers to quickly get started on new software projects. Essencium provides, for example, a fully implemented role-rights concept as well as various field-tested solutions for access management and authentication.

GNU Lesser General Public License v3.0

15 stars 3 forks source link

refactor: renamed UserDto in core project to AbstractBaseUserDto, renamed AppUserDto in subprojects to UserDto #581

Open cholakov11 opened 1 month ago

cholakov11 commented 1 month ago

Renamed UserDto class to AbstractBaseUserDto

Although the AbstractBaseUserDto class is not defined as an abstract class, I believe it should be named as abstract. This is because in our context the dto class is used to transport data of the AbstractBaseUser class. Naming the dto class also abstract should avoid any misinterpretations that this dto refers to a class other than the AbstractBaseUser.

JelmenGuhlke commented 1 week ago

@cholakov11 so your suggestion is to use the name AbstractBaseUserDto for the DTO in this PR?

cholakov11 commented 4 days ago

@JelmenGuhlke , yes. I have also implemented it this way.