Frachtwerk / essencium-frontend

Next.js based starter monorepo consisting of a component library, types, docs and a boilerplate application.

https://staging.essencium.dev

GNU Lesser General Public License v3.0

17 stars 1 forks source link

501 lib validate existing tests for loginformtsx #532

Closed qhantom closed 6 months ago

qhantom commented 6 months ago

DESCRIPTION

This PR updates and adds tests to the LoginForm.tsx component.

TO-DO

[x] implement and update tests
[x] update docs
[x] pull main & resolve merge conflicts
[x] check Vercel deployment

CLOSES

Closes #501

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	Mar 12, 2024 0:37am
docs	✅ Ready (Inspect)	Visit Preview	Mar 12, 2024 0:37am

nx-cloud[bot] commented 6 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c6cd690dab2e63dff18da7ba362aaf57bffb69d9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

- [`nx build @frachtwerk/essencium-app`](https://cloud.nx.app/runs/tziuUhAgOd?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel=10`](https://cloud.nx.app/runs/PjNPHooOiT?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

qhantom commented 6 months ago

Test is failing even after a fresh clean:install with following error: Error: Failed to resolve entry for package "@frachtwerk/essencium-types". The package may have incorrect main/module/exports specified in its package.json.

Is it working on your machine?

I forgot to set an resolve alias for the types package to point to the src directory and not the dist directory since when making a clean install, no dist directory exists. Please test again @PhilKsr

PhilKsr commented 6 months ago

Test is failing even after a fresh clean:install with following error: Error: Failed to resolve entry for package "@frachtwerk/essencium-types". The package may have incorrect main/module/exports specified in its package.json. Is it working on your machine?

I forgot to set an resolve alias for the types package to point to the src directory and not the dist directory since when making a clean install, no dist directory exists. Please test again @PhilKsr

Works fine now, thank you! 🥳