Frachtwerk / essencium-frontend

Next.js based starter monorepo consisting of a component library, types, docs and a boilerplate application.

https://staging.essencium.dev

GNU Lesser General Public License v3.0

17 stars 1 forks source link

feat: add functionality for fixedTableSize to TablePagination #575

Closed CathrinTruchan closed 3 months ago

CathrinTruchan commented 3 months ago

DESCRIPTION

In this PR the following changes have been implemented in the TablePagination component:

Hand down all Mantine Props for custom styling
Make the field for manually setting a page size optional and give the possibility to set a fixed size for the table.

To test this functionality i.e. go to app > users > index and add the property fixedTableSize to the TablePagination component.

TO-DO

[x] implement and update tests
[x] update docs
[x] pull main & resolve merge conflicts
[x] check Vercel deployment

CLOSES

closes #555

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	May 21, 2024 7:32am
docs	✅ Ready (Inspect)	Visit Preview	May 21, 2024 7:32am

nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 34206792334e5ed023c9f5fbfd9677afdeaf8fd8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

- [`nx build @frachtwerk/essencium-app`](https://cloud.nx.app/runs/YOeQfzMUIf?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel=10`](https://cloud.nx.app/runs/RavB7CHPZF?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

CathrinTruchan commented 3 months ago

@qhantom I implemented your suggestion and fixed to tiny styling issues. You can check again 👀

qhantom commented 3 months ago

@CathrinTruchan please adjust the peer deps for next in lib as well 🙂