feat: enable props forwarding for appshell mantine components

Frachtwerk / essencium-frontend

Next.js based starter monorepo consisting of a component library, types, docs and a boilerplate application.

https://staging.essencium.dev

GNU Lesser General Public License v3.0

17 stars 1 forks source link

feat: enable props forwarding for appshell mantine components #582

Closed qhantom closed 2 months ago

qhantom commented 2 months ago

DESCRIPTION

This PR enables the ability to pass all Mantine props to our custom components that forward them to the Mantine components. The win here is much higher customizability.

TO-DO

[x] implement and update tests
[x] update docs
[x] pull main & resolve merge conflicts
[x] check Vercel deployment

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	May 29, 2024 8:23am
docs	✅ Ready (Inspect)	Visit Preview	May 29, 2024 8:23am

qhantom commented 2 months ago

Looks good! I think we should implement this in all lib-components. For example the table could be more flexible. What do you think? New ticket?

Good point, let me implement it in this PR since it shouldn't take too long.

qhantom commented 2 months ago

@PhilKsr It was indeed only the table component that was missing props forwarding. Please have another look 🙂

PhilKsr commented 2 months ago

@PhilKsr It was indeed only the table component that was missing props forwarding. Please have another look 🙂

Funny xD