Frachtwerk / essencium-frontend

Next.js based starter monorepo consisting of a component library, types, docs and a boilerplate application.
https://staging.essencium.dev
GNU Lesser General Public License v3.0
17 stars 1 forks source link

refactor: pass arbitrary number of key value pairs to feedback widget #604

Closed CathrinTruchan closed 1 month ago

CathrinTruchan commented 1 month ago

DESCRIPTION

In this PR the FeedbackWidget Component has been refactored. Now its possible to give an arbitrary number of key value pairs as prop to the FeedbackWidget. This customizable additional information will be added to the email to provide more context (e.g. user language, user roles, environment, software version etc.)

TO-DO

CLOSES

closes #554

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app ✅ Ready (Inspect) Visit Preview Jul 22, 2024 10:08am
docs ✅ Ready (Inspect) Visit Preview Jul 22, 2024 10:08am
CathrinTruchan commented 1 month ago

Did you test it locally? 🙂

I tested locally, if the emails are send correctly. I did not check the incoming email, since ethereal disabled inbound email functionality (--> https://ethereal.email/help#inbound). But I can look for another service, to test it!

qhantom commented 1 month ago

Did you test it locally? 🙂

I tested locally, if the emails are send correctly. I did not check the incoming email, since ethereal disabled inbound email functionality (--> https://ethereal.email/help#inbound). But I can look for another service, to test it!

I see. Otherwise we can just merge it and test the functionality on our acceptance.

CathrinTruchan commented 1 month ago

Did you test it locally? 🙂

I tested locally, if the emails are send correctly. I did not check the incoming email, since ethereal disabled inbound email functionality (--> https://ethereal.email/help#inbound). But I can look for another service, to test it!

I see. Otherwise we can just merge it and test the functionality on our acceptance.

Found a way to test it locally and works as expected :) Added language and roles as custom properties. (The email doesn't look very nice, though 🤷‍♀️ )

Screenshot 2024-07-17 at 16 56 17
qhantom commented 1 month ago

Did you test it locally? 🙂

I tested locally, if the emails are send correctly. I did not check the incoming email, since ethereal disabled inbound email functionality (--> https://ethereal.email/help#inbound). But I can look for another service, to test it!

I see. Otherwise we can just merge it and test the functionality on our acceptance.

Found a way to test it locally and works as expected :) Added language and roles as custom properties. (The email doesn't look very nice, though 🤷‍♀️ )

Screenshot 2024-07-17 at 16 56 17

Fine for the moment I think, the styling can be adjusted in the future. I was just wondering why firstName is indented 🤔

CathrinTruchan commented 1 month ago

Did you test it locally? 🙂

I tested locally, if the emails are send correctly. I did not check the incoming email, since ethereal disabled inbound email functionality (--> https://ethereal.email/help#inbound). But I can look for another service, to test it!

I see. Otherwise we can just merge it and test the functionality on our acceptance.

Found a way to test it locally and works as expected :) Added language and roles as custom properties. (The email doesn't look very nice, though 🤷‍♀️ )

Screenshot 2024-07-17 at 16 56 17

Fine for the moment I think, the styling can be adjusted in the future. I was just wondering why firstName is indented 🤔

@qhantom: I refactored the formatting of the feedback message. I looks like this now:

Screenshot 2024-07-22 at 12 09 36

Do you want to review the last changes?