search

FractalBoy / perl-language-server

101 stars 12 forks source link

Perltidy defaults to `-et` when tabs are enabled instead of `-t` #93

Open rmzg opened 2 years ago

rmzg commented 2 years ago

Long story short, despite the documentation recommending -et over -t, -et is basically broken: https://github.com/perltidy/perltidy/issues/90

If you want sane indentation using tabs, use -t instead.

FractalBoy commented 2 years ago

If it's broken, I would defer to perltidy to fix the issue. The -t option has no option for tab size which would mean we would need to ignore that setting from the client.

rmzg commented 2 years ago

Sorry, it's probably too early in the morning, but why is there even a tab size setting? The whole point of using tabs is that I don't have to care about sizes and widths and stuff, I just say "indent by one level" and insert a tab. If you look at my example in the first comment of that bug, if PLS used -t instead it would have Just Worked.

FractalBoy commented 2 years ago

I don't know, I don't use tabs so I guess I didn't even really think it through. I suppose I'm fine switching back to -t but the perltidy documentation says that option is deprecated. So if they change their documentation to say it's no longer deprecated, I will use it.