search

FractalFir / tmf

Tight Model format is an experimental lossy 3D model format focused on reducing file size as much as posible without decreasing visual quality of the viewed model or read speeds.
MIT License
100 stars 6 forks source link

[BUG] tmf Doesn't compile with the `fast_trig` feature enabled #9

Closed nicopap closed 1 year ago

nicopap commented 1 year ago

I get a compilation error if I enable the fast_trig feature:

tmf = { version = "0.1.1", features = ["fast_trig"] }

When running cargo build I get the following compilation error:

error[E0412]: cannot find type `fprec` in this scope
  --> /github.com-1ecc6299db9ec823/tmf-0.1.1/src/normals.rs:98:27
   |
98 |     let x = fsin(asine as fprec) as FloatType;
   |                           ^^^^^ not found in this scope
   |
note: type alias `crate::utilis::fprec` exists but is inaccessible
  --> /github.com-1ecc6299db9ec823/tmf-0.1.1/src/utilis.rs:21:1
   |
21 | type fprec = f64;
   | ^^^^^^^^^^^^^^^^^ not accessible

I would expect tmf to compile regardless of the enabled features. tmf compiles correctly when fast_trig is not enabled.

FractalFir commented 1 year ago

Should be fixed in a6ab33ff3b5303a93fa42bdfdcd7fd0034e9218b.