search

FractalUK / KSPInterstellar

KSP Instellar Mod for Kerbal Space Program
115 stars 67 forks source link

Fix for incompatibility with LazTek Dragon V2 (in specific) and decoupleable solar panels (in general). #47

Closed cerebrate closed 9 years ago

cerebrate commented 9 years ago

Please ignore most of this pull request: the majority of the changes were necessary just to get it to compile (the .csproj seemed to be missing for FNPlugin?)

The exception is the change to FNPlugin/FNSolarPanelWasteHeatModule.cs .

I discovered that the problem with the LazTek Dragon mod and Interstellar together was down to the referenced force_activate() call in FNSolarPanelWasteHeatModule.cs. When ModuleDecouple exists on the same part as the stock solar panel module, to which FNSolarPanelWasteHeatModule is automatically added, this causes immediate and repetitive decoupling of that part, in this case the Dragon trunk.

This patch prevents the force_activate() call when ModuleDecouple is present on the associated part. I am unfortunately not familiar enough with the KSP code to fully understand the impact this will have on waste heat calculations for decouplable solar panels, but it does permit such parts to be useful (and the vessel in this case launchable) until a better fix can be devised.

Regards,

Alistair

cerebrate commented 9 years ago

This is broken and best ignored.