FractalUK / KSPInterstellar

KSP Instellar Mod for Kerbal Space Program
115 stars 67 forks source link

Seismic impact experiment includes impacts that have been undone by quickloads #82

Open Monchoman45 opened 7 years ago

Monchoman45 commented 7 years ago

I dropped four seismometer probes onto Minmus from orbit to do an impact experiment, but I accidentally crashed my last one into the planet. So, naturally, I quickloaded and landed it properly, then crashed a spent fuel tank into the surface for the experiment.

However, when I pulled the impact data, I got the data for the probe impact - the one I crashed accidentally - even though I did a quickload, meaning my seismometers were providing me with data from an impact that didn't actually occur (in their timeline, so to speak). This reduced my science yield, because when I accidentally crashed my probe, I only had 3 seismometers recording.

I looked into what caused this; it looks like seismometer data is stored in a standalone .cfg file; it isn't tied to a save file.

An ideal solution would be to store impact data in save files rather than the mod config file, but I assume this wasn't done for technical reasons. Another potential solution would be to store the UT of the impact, then, when a save is loaded, check for and remove impacts that have happened in the future. This could potentially cause problems if you were to load an old save, then load a new one, but I don't think people do that particularly often - quickloading is much more common, especially when accidentally crashing something, so this seems like an acceptable trade off.

sswelm commented 7 years ago

mmm although I could fix it, due to my unfamilarity with it's code, it would require a lot of time.

Preferable this functionality is taken over by mods that specialize in generic planetary science experiments.