FractalUK / KSPInterstellar

KSP Instellar Mod for Kerbal Space Program
115 stars 69 forks source link

Tech tree green "upgrades" are free in Career mode, despite having a clearly listed purchase price #90

Open AncalagonX opened 6 years ago

AncalagonX commented 6 years ago

I'm using about 100 various mods, which I'll list in a follow-on comment, though only a few are truly "major" mods while most are minor improvements/QoL additions.

Problem: Whenever I pay science points to unlock a new tech tree node that has upgrades, the price for purchasing each individual upgrade is listed correctly. However, when I "purchase" the upgrade, no kerbal cash is deducted and I end up with the upgrade for free.

At least, I assume the upgrade is successfully applied—I'm not sure how to check to see if my Timberwind, etc. are actually the upgraded models.

One thing for sure is working properly, despite the free cost bug: Once I "purchase" an upgrade (for free, despite a cost being listed) it cannot be purchased again. i.e. I can't erroneously re-buy the same upgrade multiple times so the bug doesn't affect that part of it.

One more thing that's working properly: Although no funds are ever deducted for "Upgrade" purchases, I still cannot purchase upgrades if I don't at least have enough cash reserves to cover the cost of the upgrade. For example, I can't pay buy one of the Daedulus Upgrades because I don't have 6 million space bucks in my wallet. I am certain that once I have that amount and click "Upgrade", it will cost me 0 kerbucks in the end, which is the core of this bug report.

Let me know if there's anything I can do to help you track this down or if it's out of the scope of KSPI-E issue resolution.

sswelm commented 6 years ago

Not sure but I thought this was some career setting which determined if upgrades cost resources or not or automatically unlocked parts when buying a tech node. which by default is linked to the difficulty.

AncalagonX commented 6 years ago

I don't see this Career Option in the difficulty menu anywhere. There is a checkbox for "Part Upgrades", but I believe that only controls whether upgrade functionality is enabled for modders to take advantage of. Mine is checked.

AncalagonX commented 6 years ago

A "green upgrade" for another mod correctly deducted the kerbal bucks as expected, while KSPI-E still gives me them for free.

Here is my mod list, although the "free green upgrades despite price being listed" bug seems to affect only KSPI-E upgrades:

KSP: 1.4.3 (Win64) - Unity: 2017.1.3p1 - OS: Windows 10  (10.0.0) 64bit
000_AT_Utils - 1.6
ClickThroughBlocker - 0.1.6.5
Filter Extensions - 3.2.2.3
Toolbar - 1.7.17.11
USI Tools - 0.12
ToolbarControl - 0.1.6.10
AllYAllContinued - 0.11.14.4
Astronomer's Visual Pack - 3.7.2
AutoAction - 1.10.2
B9 Animation Modules - 1.2.1
B9 Part Switch - 2.3.2
B9 Aerospace HX Parts - 6.5.1
BAM - 1.3.2.2
BetterTimeWarpContinued - 2.3.10.1
ChampagneBottleRedux - 0.3.8.2
Chatterer Extended - 0.6.2
Chatterer - 0.9.95.2110
Community Category Kit - 3.0
Community Resource Pack - 0.10
CommunityTechTree - 3.3.2
Contract Configurator - 1.25
Contract Pack: Anomaly Surveyor - 1.7.1
Contract Pack: Field Research - 1.2.1
Contract Pack: Bases and Stations - 3.7.0.4
Contract Pack: RemoteTech - 2.1.4
Contract Pack: Tourism Plus - 1.5.2
Community Terrain Texture Pack - 1.0.3
CustomBarnKit - 1.1.17
DistantObjectEnhancement - 1.9.1
DMagic Orbital Science - 1.3.0.12
CapCom Mission Control On The Go - 1.0.2.8
Contract Parser - 1.0.8
Contracts Window Plus - 1.0.8.2
Progress Parser - 1.0.9
Easy Vessel Switch - 1.6.6640.41793
EditorExtensionsRedux - 3.3.19.3
Environmental Visual Enhancements - 1.4.2.2
EVAEnhancementsContinued - 0.1.13.1
Firespitter - 7.9
Flexible Docking - 1.0.6
FuseBoxContinued - 0.1.16.5
GroundConstruction - 2.0.1
HeatControl - 0.4.5
HideEmptyTechTreeNodes - 1.0.4
Interstellar Fuel Switch - 3.6
JanitorsCloset - 0.3.4.1
K2CommandPodContinued - 1.1.8.4
RasterPropMonitor - 0.30.5
Kerbal Attachment System - 0.6.4
Kerbal Engineer Redux - 1.1.5.2
Kerbal Foundries - 2.2.6.16
Kerbal Inventory System - 1.12.6700.37736
Kopernicus - 1.4.3.2
KSP-AVC Plugin - 1.2.0.2
KSPRescuePodFix - 1.3.2.11
KSPWheel - 0.11.9.27
Lithobrake Exploration Technologies - 0.4
LoadingScreenManager - 1.2.5
MagiCore - 1.3.1
Maeneuver Node Evolved - 1.0.4
ModularFlightIntegrator - 1.2.5
NavBallDockingAlignmentIndicatorCE - 1.0.4.2
Docking Port Alignment Indicator - 6.8.2
Final Frontier - 1.4.2.3375
S.A.V.E - 1.5.2.3063
OuterPlanetsMod - 2.2.1
PatchManager - 0.0.16
PlanetShine - 0.2.6.1
Procedural Fairings - 1.4.3.4
Procedural Parts - 1.3.15
QuickSearch - 3.2.1.1
RealChute - 1.4.6
Recovery Controller - 0.0.3.2
RemoteTech - 1.8.11
ResearchBodies - 1.9.7
SafeChute - 2.1.12
SCANsat - 1.1.8.6
Science Relay - 1.0.5.1
Ship Manifest - 5.2.1
Space Age - 0.2.6
StationScienceContinued - 2.4.1
Stock Visual Enhancements - 1.3.0.4
Strategia - 1.7.2
TAC Fuel Balancer - 2.18
TakeCommandContinued - 1.4.12.1
TarsierSpaceTechnology - 7.3
TextureReplacerReplaced - 0.5.4
Tracking Station Evolved - 1.0.3
Trajectories - 2.2
Kerbal Alarm Clock - 3.9.1
Alternate Resource Panel - 2.9.3
Transfer Window Planner - 1.6.3
TweakScale - 2.3.12
USI Core - 0.7
Asteroid Recycling Tech - 0.13
USI Exploration Pack - 0.11
Freight Transport Tech - 0.10
Konstruction - 0.5
USI-LS - 0.9
MKS - 0.55
Universal Storage - 1.4
Unmanned before Manned - 1.3.0.2
Unmanned before Manned - Challenge - 1.3
EVAParachutesAndEjectionSeats - 0.1.15.2
KSP Interstellar Extended - 1.19.3
Waypoint Manager - 2.7.2
[x] Science! - 5.15
sswelm commented 6 years ago

Wait are you referring to KSPIE part upgrades, they are no real part upgrades, more like tech helper that tells a player a particular part capabilities get upgraded when are particular technode is unlocked

AncalagonX commented 6 years ago

Please see the mouseover text on this green upgrade for the Daedalus module which I haven't purchased yet. It wants me to spend 6mil kerbal bucks to unlock it. When I do so, no funds are deducted. Other mods which use this "green upgrade" unlock system correctly deduct funds.

Perhaps there is some mod interaction or something extra going on here?

imxlxru 1

sswelm commented 6 years ago

Possibly. Daedalus Fusion Engine Upgrade should not cost any credits, so when you attempt to buy it, no credits can be written of from your account. The 6000000 seem to refer to the entry cost, which you only have to buy once at most at the tech node where the part gets unlocked. In the above case, the Deadalus Fusion Engine is supposed to receive a free power upgrade when Fusion Power gets unlocked