search

FractalizeR / phpSweetPDO

Small, quick and smart PDO wrappper for PHP
Apache License 2.0
15 stars 2 forks source link

Symphony Events #1

Closed calmdev closed 10 years ago

calmdev commented 10 years ago

Hello,

Just wondering if you're still maintaining this library. I know there isn't many watchers here, but it's a nice PDO code base. I've been using it a lot lately and today decided to look into the the Symphony events, but it appears that the integration within PHPSweetPDO is based on an older version of Symphony.

I was wondering, if maybe it should be updated. I could give it a try and submit a PR, but in addition it would be nice to provide a bit more information in the README about using the events. Do we need both Silex and Symphony to make it work? Just want to make sure I am not including more than what's needed.

Nice work.

FractalizeR commented 10 years ago

Hi.

Well, if you give me a push request, for sure, I will update codebase.

I used this lib a while ago :) We don't need Symphony framework to be installed, just Symfony Event Dispatcher component: https://github.com/symfony/EventDispatcher You can install this component alone for example via PEAR: http://pear.symfony.com/

Best regards, Vladislav "FractalizeR" Rastrusny http://www.fractalizer.ru FractalizeR@yandex.ru

2013/10/25 Levi Lewis notifications@github.com

Hello,

Just wondering if you're still maintaining this library. I know there isn't many watchers here, but it's a nice PDO code base. I've been using it a lot lately and today decided to look into the the Symphony events, but it appears that the integration within PHPSweetPDO is based on an older version of Symphony.

I was wondering, if maybe it should be updated. I could give it a try and submit a PR, but in addition it would be nice to provide a bit more information in the README about using the events. Do we need both Silex and Symphony to make it work? Just want to make sure I am not including more than what's needed.

Nice work.

— Reply to this email directly or view it on GitHubhttps://github.com/FractalizeR/phpSweetPDO/issues/1 .

FractalizeR commented 10 years ago

What exactly doesn't work with EventDispatcher? What is the error you get?

calmdev commented 10 years ago

Sorry for the delay - so, looking at the source phpSweetPDO needs to be updated to work with the latest EventDispatcher. Looking at the connection constructor you can see that it is expecting \sfEventDispatcher, but that has been given a new namespace in 2.36 stable which is Symfony\Component\EventDispatcher.

There appears to be a couple other small changes like this too. I should be able to submit a pull request within the next couple days if you're still interested in merging an update.

FractalizeR commented 10 years ago

Sure, I am interested. Waiting for a pull. ;)

Best regards, Vladislav "FractalizeR" Rastrusny http://www.fractalizer.ru FractalizeR@yandex.ru

2013/11/5 Levi Lewis notifications@github.com

Sorry for the delay - so, looking at the source phpSweetPDO needs to be updated to work with the latest EventDispatcher. Looking at the connection constructorhttps://github.com/FractalizeR/phpSweetPDO/blob/master/phpSweetPDO/Connection.php#L56you can see that it is expecting \sfEventDispatcher, but that has been given a new namespace in 2.36 stablehttp://pear.symfony.com/#eventdispatcherwhich is Symfony\Component\EventDispatcher.

There appears to be a couple other small changes like this too. I should be able to submit a pull request within the next couple days if you're still interested in merging an update.

— Reply to this email directly or view it on GitHubhttps://github.com/FractalizeR/phpSweetPDO/issues/1#issuecomment-27782111 .

FractalizeR commented 10 years ago

Commited. Thanks a lot for your attention!