Fragtality / PilotsDeck

Directly control the FlightSim from your StreamDeck!
Other
93 stars 6 forks source link

vJoyDrv button on SD+ dial does not trigger button press #70

Closed pre-martin closed 2 weeks ago

pre-martin commented 2 months ago

This issue affects the current master (development) version.

When a VJoyDrv button is assigned to a SD+ dial, there is no button pressed. Only if you rotate the dial fast enough, so that the Stream Deck software reports abs(ticks) > 1, the PilotsDeck plugin will trigger a joystick button press.

The reason is that https://github.com/Fragtality/PilotsDeck/blob/7253837598f19b44346a2f25e5104a783fa6714c/Plugin/Simulator/ConnectorNone.cs#L109 always calls ClearSetDriverButton(..., false). Only with ticks > 1 the code starts to send true followed by false.

Fragtality commented 1 month ago

Good catch!

How does the latest Build work out?

Since you have a Use-Case for such a Combo, please also test if it both works with the Composite Actions and the "Classic" Actions!

pre-martin commented 1 month ago

Thank you, it works again with the "Display Value" action.

I will make more tests later.

pre-martin commented 1 month ago

Works also with all other actions. Also with the Composite action. 👍

Two remarks (not related to this ticket, but to your plugin):

Fragtality commented 1 month ago

Thanks for the Feedback ❤️ It's always great to know that the Work and the Ideas behind it are recognized!

The funny Thing about the two new Features you mentioned: I got rid of most Scripts for the FCU/AP-Panels since the Composite Action can handle the simple Logics for that on its own (for Example on the A32NX) ^^

pre-martin commented 1 month ago

Unfortunately I did not test "dial press" after your fix. "dial left" and "dial right" work perfectly, but on dial press, the joystick buttons remains pressed forever.

Fragtality commented 1 month ago

Nope, works.

pre-martin commented 1 month ago

If I put the same vJoy button (e.g. 1:10) on both "DIAL_DOWN" and "DIAL_UP" of the Composite Action, it works. If I only put 1:10 on "DIAL_DOWN" the joystick button is never released. The documentation says:

Non-Toggling vJoy Buttons will behave like any normal Joystick Button - they are down/set as long as the StreamDeck Key/Dial is down (and go up/cleared when the Key/Dial goes up again).

Fragtality commented 1 month ago

Ohhhh - that Part must be reformulated! D'OH

Yes that is true for the "classic" Actions, not for the Composite Action.

Fragtality commented 2 weeks ago

Readme updated image