vJoyDrv button on SD+ dial does not trigger button press

Fragtality / PilotsDeck

Directly control the FlightSim from your StreamDeck via FSUIPC!

Other

91 stars 6 forks source link

vJoyDrv button on SD+ dial does not trigger button press #70

Open pre-martin opened 1 day ago

pre-martin commented 1 day ago

This issue affects the current master (development) version.

When a VJoyDrv button is assigned to a SD+ dial, there is no button pressed. Only if you rotate the dial fast enough, so that the Stream Deck software reports abs(ticks) > 1, the PilotsDeck plugin will trigger a joystick button press.

The reason is that https://github.com/Fragtality/PilotsDeck/blob/7253837598f19b44346a2f25e5104a783fa6714c/Plugin/Simulator/ConnectorNone.cs#L109 always calls ClearSetDriverButton(..., false). Only with ticks > 1 the code starts to send true followed by false.

Fragtality commented 20 hours ago

Good catch!

How does the latest Build work out?

Since you have a Use-Case for such a Combo, please also test if it both works with the Composite Actions and the "Classic" Actions!

pre-martin commented 17 hours ago

Thank you, it works again with the "Display Value" action.

I will make more tests later.

pre-martin commented 16 hours ago

Works also with all other actions. Also with the Composite action. 👍

Two remarks (not related to this ticket, but to your plugin):

The support of LUA scripts directly from the plugin is mind blowing. For example, all my EFIS buttons for the FBW A32NX are dimmed when there is no AC power on the aircraft. Or the baro on the SD+ dial displays "88.88" during the lights test.
Composite actions are also awesome. I am just about to discover the endless possibilities of this feature.

Fragtality commented 16 hours ago

Thanks for the Feedback ❤️ It's always great to know that the Work and the Ideas behind it are recognized!

The funny Thing about the two new Features you mentioned: I got rid of most Scripts for the FCU/AP-Panels since the Composite Action can handle the simple Logics for that on its own (for Example on the A32NX) ^^