search

Frames-Proj / frames

6 stars 6 forks source link

Video cache #107

Closed GrahamGoudeau closed 7 years ago

GrahamGoudeau commented 7 years ago

Closes #104

ethanpailes commented 7 years ago

This looks really clean.

It looks like the video cache only works in-memory, and most of the value-added from having a history page is that we don't have to re-download videos after restarting the app. The video files are going to be there on disk anyway, so it is worth listing them.

If you could add the ability to serialize the video metadata and access time to some location in the CONFIG.APP_HOME_DIR, and then read it on startup, that would be ideal.

nicholasyan commented 7 years ago

With the changes @ethanpailes was talking about, looks good to me.

ethanpailes commented 7 years ago

I just merged #114 BTW

ethanpailes commented 7 years ago

It doesn't look like this will get maintained.