add 'Off' setting for power LED

FrameworkComputer / EmbeddedController

Embedded Controller firmware for the Framework Laptop

BSD 3-Clause "New" or "Revised" License

935 stars 62 forks source link

add 'Off' setting for power LED #12

Open hauntingEcho opened 2 years ago

hauntingEcho commented 2 years ago

resolves #11

upfront warning - I have no experience in firmware, and haven't worked with C in around a decade (or ever in a professional context). I haven't yet loaded this onto my own laptop to test as it's my daily-driver. Skepticism / thorough review is warranted :)

breath length is left alone, since it's breathing from 0 to 0. Disabling breath may be better for battery life?

PeterHindes commented 1 year ago

Looks like it would work

AkechiShiro commented 9 months ago

Any plans on this getting merged any time ?