search

FrameworkComputer / EmbeddedController

Embedded Controller firmware for the Framework Laptop
BSD 3-Clause "New" or "Revised" License
958 stars 64 forks source link

Possibly use a "baseboard" to unify hx20 and hx30 #19

Closed DHowett closed 1 year ago

DHowett commented 2 years ago

Depending on how similar the hx* boards are, it may be possible--and perhaps advantageous!--to unify their implementations as a baseboard (see the baseboard directory for other examples.)

That would make it easier to abstract, say, the input cover/key layout and PS/2 emulation bits and drive bug fixes to both platforms simultaneously. Similar thoughts about the UCSI implementation, if the hx20/30 share one of those.

DHowett commented 2 years ago

Barring this, perhaps it would be nice if the hx20 and hx30 board directories weren't on separate branches? They don't necessarily need to be unified, but... as the potential author of a number of changes that should apply to both 11th and 12th gen boards, it complicates deployment and development to have them on separate branches.

JohnAZoidberg commented 1 year ago

We have combined them with a baseboard. I extracted much of the duplicated code into there. The next hx20 and hx30 releases will contain those changes.