Closed sjg20 closed 1 year ago
CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
You can retrigger this bot by commenting recheck in this Pull Request
This is possibly an incorrect fix. Looking at the same functionality in the hx20 branch, the offending line is just de-indented - https://github.com/FrameworkComputer/EmbeddedController/blob/38c1b38254793a2ed25861330ebc786daa5b48fb/board/hx20/cypress5525.c#L973
If this is an actual issue, it needs to be resolved in the hx20 board too.
This seems to be handling an error case incorrectly.
board/hx30/cypress5525.c: In function 'cyp5525_port_int': board/hx30/cypress5525.c:974:9: error: this 'if' clause does not guard... [-Werror=misleading-indentation] 974 | if (rv != EC_SUCCESS) | ^~ board/hx30/cypress5525.c:976:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 976 | print_pd_response_code(controller, | ^
~~~~~Signed-off-by: Simon Glass sjg@chromium.org