search

FrameworkComputer / EmbeddedController

Embedded Controller firmware for the Framework Laptop
BSD 3-Clause "New" or "Revised" License
958 stars 64 forks source link

Missing git tag info? #4

Open junaruga opened 2 years ago

junaruga commented 2 years ago

I noticed this repository doesn't have any tag info.

$ git tag -n

I can see the tag info on the upstream chromium ec repository.

$ git remote -v
origin  https://chromium.googlesource.com/chromiumos/platform/ec (fetch)
origin  https://chromium.googlesource.com/chromiumos/platform/ec (push)

$ git tag -n | tail
v1.9308_B.0     firmware branch v1.9308_B.0
v1.9311_70_mp   firmware branch v1.9311_70_mp
v1.9311_mp      firmware branch v1.9311_mp
v2.0.0          Adding a new tag to reset revision count
v2.1.0          Adding a new tag to reset revision count in the firmware-grunt-11031.B branch
v2.14294_prepvt.0 firmware branch v2.14294_prepvt.0
v2.2.0          Adding a new tag to reset revision count in the firmware-nocturne-10984.B
v2.3.0          Adding a new tag to reset revision count in the firmware-servo-11011.B
v2.4.0          Adding a new tag to reset revision count
v2.94_pp.0      firmware branch v2.94_pp.0

I expected there are the tags "v3.2", "v3.6", "v3.7" used to ship BIOS version 3.02, 3.06, 3.07 and etc on this repository. Is the missing git tag info intentional?

kiram9 commented 2 years ago

I only exported the code, I can push tags as well, but our bios builds and upstream tags do not align well as there is some overlap.

junaruga commented 2 years ago

OK. I agree on not managing the upstream tags on this downstream repository. So, maybe you are managing the downstream, this repository specific tags used on your bios builds, right? I have no experience of developing a firmware. So, I might be wrong. But I suppose that the downstream specific git tags are useful to know the code or commits included in a BIOS version. You might use a downstream unique version string such as "<a-prefix>-v3.02" to avoid confusing from a upstream tag or just v3.02 or v3.2.

hauntingEcho commented 2 years ago

I'm not certain there's value in any of the upstream tags, honestly. Having tags that align with Framework's releases are the ones that matter, so we can try use a specific release version with one tweak rather than a between-release repo state + that tweak.