FrameworkComputer / EmbeddedController

Embedded Controller firmware for the Framework Laptop
BSD 3-Clause "New" or "Revised" License
957 stars 64 forks source link

lotus: lower threshold for Apple 96W and TS4 98W chargers #44

Open Terrails opened 1 month ago

Terrails commented 1 month ago

This pull request lowers the required AC charger power to get the higher SoC power limits on chargers that are almost 100W.

I and most likely a decent chunk of Framework 16 users use a Caldigit TS4 dock which unfortunately does not provide the full 100W required to get the higher power limits, but instead exposes itself as a 20V 4.9A charger (98W) as can be seen from the output of ectool console:

[434.789900 CL: p3 s0 i4900 v20000]

I have initially wanted to drop this limit down to 98W, but there are other chargers like the Apple 96W USB-C charger and it would also benefit the users of those to drop this threshold down to 96W so that performance is not limited while plugged into these near 100W chargers.

I have already tested this change on my non-dGPU FW16 and it has been working flawlessly.