Avoid resetting charge_max_level during CHG_LIMIT_GET_LIMIT

FrameworkComputer / EmbeddedController

Embedded Controller firmware for the Framework Laptop

BSD 3-Clause "New" or "Revised" License

935 stars 62 forks source link

Closed DHowett closed 1 year ago

DHowett commented 2 years ago

Reading into charging_maximum_level overwrites CHG_LIMIT_OVERRIDE; GET_LIMIT should not change global state.

Fixes #6.

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

DHowett commented 2 years ago

I have read the CLA Document and I hereby sign the CLA

DHowett commented 2 years ago

I'm not certain about the "labeler" failure:

Error: HttpError: Resource not accessible by integration
Error: Resource not accessible by integration

DHowett commented 1 year ago

Moved this over to baseboard/fwk. Thanks again for doing all the baseboard stuff, folks :smile: