FrameworkComputer / inputmodule-rs

Framework Laptop 16 Input Module SW/FW
MIT License
223 stars 24 forks source link

Screen is set on every USB command #108

Open Maxfojtik opened 2 months ago

Maxfojtik commented 2 months ago

At this line you set the entire screen every time a command is parsed:

https://github.com/FrameworkComputer/inputmodule-rs/blob/13efc56a0bc0b93495195197c64e6d7bf22cd119/ledmatrix/src/main.rs#L497

This is very inefficient when streaming data over the USB connection and makes framerates terrible.

The display is also getting set 32 times a second at this line, even if the animation is already finished.

https://github.com/FrameworkComputer/inputmodule-rs/blob/13efc56a0bc0b93495195197c64e6d7bf22cd119/ledmatrix/src/main.rs#L398