FrameworkComputer / inputmodule-rs

Framework Laptop 16 Input Module SW/FW
MIT License
223 stars 24 forks source link

README is wrong regarding panic written to flash #27

Closed jannic closed 1 year ago

jannic commented 1 year ago

The README says: "Additionally the panic message is written to flash" Unless I'm missing something, this is not true. It looks like you are using rp2040-panic-usb-boot, and that's not writing to flash.

It uses a RAM area usually used as a flash cache. So by disabling the flash cache, the panic handler can be sure that this memory is unused and the panic message can be stored there without overwriting anything that could be useful for debugging.

However, in contrast to flash memory, that RAM area will get erased once the rp2040 gets rebooted.

JohnAZoidberg commented 1 year ago

Yes, you're definitely right. I'm just using your rp2040-panic-usb-boot crate with its default behavior.