Lotus.lowpower - Githubissues

FrameworkComputer / qmk_firmware

Fork of QMK for the Framework Laptop 16

GNU General Public License v2.0

88 stars 29 forks source link

Lotus.lowpower #25

Closed kiram9 closed 1 year ago

kiram9 commented 1 year ago

Reduce power consumption based on sleep# control. However power consumption is still not great.

Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[ ] My code follows the code style of this project: C, Python
[ ] I have read the PR Checklist document and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

KarlK90 commented 1 year ago

The only periodic irq's that come to mind in this rather barebones QMK configuration are the SOF USB interrupts which are enabled by default (and needed). Is the USB bus suspended in sleep mode?

KarlK90 commented 1 year ago

@kiram9 you might want to try out this PR https://github.com/qmk/qmk_firmware/pull/21656 which gets rid of the SOF interrupts that I suspect to wake the keyboard more often than necessary. There have also been multiple PRs to the RP2040 USB driver in ChibiOS-Contrib which should be picked up.

github-actions[bot] commented 1 year ago

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] commented 1 year ago

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]