Fix keycode for numpad equal key

icedream commented 6 months ago

Description

This fixes the equal key code on the Framework Laptop 16 Numpad module to KC_PEQL.

The change is based off the latest tag/branch used, I'm not sure which one is the development branch to do pull requests against. Please let me know if this needs to be retargeted.

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Keyboard (addition or update)
[x] Keymap/layout/userspace (addition or update)
[ ] Documentation

Issues Fixed or Closed by This PR

FrameworkComputer/qmk_firmware#30

Checklist

[x] My code follows the code style of this project: C, Python
[x] I have read the PR Checklist document and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

icedream commented 6 months ago

Tested with evtest:

Event: time 1710020268.202886, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70067
Event: time 1710020268.202886, type 1 (EV_KEY), code 117 (KEY_KPEQUAL), value 1
Event: time 1710020268.202886, -------------- SYN_REPORT ------------
Event: time 1710020268.322046, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70067
Event: time 1710020268.322046, type 1 (EV_KEY), code 117 (KEY_KPEQUAL), value 0
Event: time 1710020268.322046, -------------- SYN_REPORT ------------
Event: time 1710020269.247817, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70067
Event: time 1710020269.247817, type 1 (EV_KEY), code 117 (KEY_KPEQUAL), value 1
Event: time 1710020269.247817, -------------- SYN_REPORT ------------

github-actions[bot] commented 4 months ago

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

icedream commented 4 months ago

It was pointed out in https://github.com/FrameworkComputer/qmk_firmware/issues/30#issuecomment-2016423115 that changing this to its technically correct keycode may not be a good idea for Windows as it doesn't know how to properly handle it. I'll leave it open for now but won't push the PR for merge further.

I do not run Windows myself on the FW16 so I have no way to properly test this.

github-actions[bot] commented 2 months ago

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] commented 1 month ago

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

FrameworkComputer / qmk_firmware