FrameworkComputer / qmk_firmware

Fork of QMK for the Framework Laptop 16
GNU General Public License v2.0
80 stars 19 forks source link

[Feature Request] Add new safe keycode definition to framework_keycodes enum #35

Open nicknimchuk opened 4 months ago

nicknimchuk commented 4 months ago

Feature Request Type

Description

In the framework.h file for the Framework 16 keyboard, please add an additional keycode at the end that can be referenced in keymaps. It would likely look like this:

enum framework_keycodes {
  // Custom keycode to change screen modes (e.g. enable external screen)
  KC_SCRN = SAFE_RANGE,
  FN_LOCK,
  FW_SAFE_RANGE,
};

This would allow for custom keymaps to add keycodes in a robust manner, such as:

enum cool_keymap_keycodes {
  NEAT_BUTTON = FW_SAFE_RANGE,
  ANOTHER_BUTTON,
};
nicknimchuk commented 3 months ago

On further investigation, it looks like the keyboard-level files should be using QK_KB_0 as the start of the keyboard-specific keycodes, not SAFE_RANGE. That would mean that no FW_SAFE_RANGE would be needed, since keymap-specific keycodes could just use SAFE_RANGE then.

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs. For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.