github-actions[bot]
commented
2 weeks ago Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.
heumann-a
As mentioned in the QMK Guidelines all _user() functions should optimally (in best case never) used by the keyboards to be available for the keymap / user to implement own stuff.
Description
In your Macropad and Numpad keyboard you used keyboard_post_init_user() which should be used on keymap instead of keyboard level. For this i moved the functions to their respective default keymap, where they should be. The same or even more is important for layers which are specific for each keymap and should definitely only defined inside the respective keymaps (user-wide keymaps are an exception but since this is a keyboard folder, it is not applicable)
This Default keymap also serves as template to create an own keymap layout, so the code is still visible for everyone who wants to create or fork from it.
Types of Changes
Issues Fixed or Closed by This PR
Checklist
PS: If approved and considered correct, pls ping me and i would like to fix the other _user() functions too, that i found. Want to avoid doing multiple PRs for nothing if you guys think otherwise and remodel it differently.