search

Franc1sco / Fortnite-Emotes-Extended

Fortnite Emotes plugin with all the private emotes included
https://forums.alliedmods.net/showthread.php?t=318981
GNU General Public License v3.0
52 stars 31 forks source link

Latest Update causing Segmentation Faults #8

Closed JamsRepos closed 5 years ago

JamsRepos commented 5 years ago

Unsure on the cause, might me when people run the command to open the menu but either way, something in the latest update is causing segmentation faults and crashing servers.

Franc1sco commented 5 years ago

Try the changes in the dev branch https://github.com/Franc1sco/Fortnite-Emotes-Extended/tree/dev

JamsRepos commented 5 years ago

Nope, causing the same issues.

Franc1sco commented 5 years ago

updated.

JamsRepos commented 5 years ago

Still the same I'm afraid.

Franc1sco commented 5 years ago

Ok tell me exactly after what commit it start to crash

JamsRepos commented 5 years ago

Well b362ad06ae0b4b4f2f0646c66414632f1af57fee wouldn't load on my server and then it started to work when uploading 4395d33321802e2cceea3a162ca6bafe0cabb50f but then the crashes happened. So it could be either those two. I am currently using d84ebbdb88d0b90707d98941bffedf846470467c

Franc1sco commented 5 years ago

I merged it with previous version, try https://github.com/Franc1sco/Fortnite-Emotes-Extended/tree/dev

JamsRepos commented 5 years ago

It seems to be working now, I also suggest turning down the volume of the music as it can be quite overbearing. I normally rock around 0.4.

https://github.com/Franc1sco/Fortnite-Emotes-Extended/blob/b12d87122438cf4ded484e7dba1fa73deb723f05/addons/sourcemod/scripting/fortnite_emotes_extended.sp#L490

Franc1sco commented 5 years ago

Ok updated to the master repo.

About sound i will add a cvar for it.