gabarit (fix): fixed serve function being created multiple times - Githubissues

France-Travail / gabarit

Gabarit : kickstart your data science project from scratch

GNU Affero General Public License v3.0

58 stars 11 forks source link

gabarit (fix): fixed serve function being created multiple times #159

Closed LexABzH closed 1 year ago

LexABzH commented 1 year ago

✒️ Context

Experimental predict proba : serve function was created each time the experimental_predict_proba was called, which is very slow.

[x] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Other, please describe:

🧱 Description of Changes

Moved the serve function creation outside of the main function. This is now a model's method.

[x] This is a change for the NLP template
[x] This is a change for the NUM template
[ ] This is a change for the VISION template
[ ] This is a change for the API template
[ ] This changes how templates are generated (i.e. a Jinja change)

🩺 Testing

Tested performance : it works.

[x] This change does not need new tests
[ ] Added/Updated unit tests
[ ] Added/Updated functionals tests (i.e. e2e)

🔗 References

Issue: Closes #158

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the GNU AFFERO GENERAL PUBLIC LICENSE.