Get-answer: extend visibility to thread viewer and user who validated the task - Githubissues

France-ioi / AlgoreaBackend

Backend for the new Algorea platform

MIT License

1 stars 2 forks source link

Get-answer: extend visibility to thread viewer and user who validated the task #1042

Open smadbe opened 5 months ago

smadbe commented 5 months ago

Motivations

Currently, only owners and observers (with answer watch perm on the item and watch perm on the participant) could get an answer (by its id).

We have two new use cases where we would like users to be able to view an answer:

a user who has can_watch: result on the item, can watch the participant and who has validated the activity
with the forum, some other users may know about the answer (to help the user), and so should be able to get an answer by id

Subtasks

[ ] allow a user who has can_watch: result on the item, who can watch the participant and who has validated the activity, to view an answer
[ ] Make sure a user who sees a thread, can see answers it may mention, so in practice apply the permission as the thread reading permissions here

Notes

The forum part should be similar to the service. However, the perm rule has just changed and the issue fixing it is not started yet #1163
The 4 rules are not independent, possibly it is possible to "optimize" a lot by removing overlapping rules