Closed GeoffreyHuck closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
1393a31
) to head (073cb2a
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For now in the worst case, the items propagation took ~6s. Since the process acquires a lot of write locks, it makes other select queries for other services wait for this amount of time. This doesn't fully solve the waiting problem though. It just makes the wait faster because the transactions are now smaller. The code is a bit weird because we still have two cases where the group propagation have to be executed inside a bigger transaction:
CreateRelation
function, used in thegroupAddChild
and the accessTokenCreate andrefreshToken
(for the badges) services.DeleteRelation
function, used only in thegroupRemoveChild
service. Once those cases are removed, the code can be simplified, and look more like the other propagations.