Adapt invitation service to current needs

France-ioi / AlgoreaBackend

Backend for the new Algorea platform

MIT License

1 stars 2 forks source link

Adapt invitation service to current needs #1070

Closed GeoffreyHuck closed 3 weeks ago

GeoffreyHuck commented 2 months ago

fixes #1056

Modifications of service invitationsView:

only return actual invitation the user has received (that he has not approved yet, which has not been removed, ...), no more join request things
remove the action" in the output, not needed anymore
include the 3 require approval fields for the group
inviting_user in response is not nullable anymore
remove within_weeks in response, not useful anymore

Review

Easier to review commit by commit. The details are in commit messages.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ec53a8f) to head (8ccffc7).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1070 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 236 236 Lines 14302 14295 -7 ========================================= - Hits 14302 14295 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

smadbe commented 2 months ago

Let me merge it. As it breaks the current API, I'll merge+deploy when I am sure we can fix the frontend immediately.