Closed GeoffreyHuck closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
896e0ef
) to head (7b9f3c4
). Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
fixes #1044
Encryption Algorithm
There are a few warnings on StackOverflow about using
AES-128-ECB
andAES-256-CBC
, so the one implemented isAES-256-GCM
(it includes a signature, which seems like a good idea but I don't know much about cryptography).The most important thing for security is to make sure the
nonce
is always different.Notes on the implementation:
nounce
32 bytes
of the secret are used as the key, because the key must be32 bytes
forAES-256
.I'm not sure what the
tag (optional) the public tag generated by the encoding (for instance in GCM)
means (in the issue).Review
Easier to review all at once. But as usual the individual commit messages contain more info.