Closed GeoffreyHuck closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
dd140bf
) to head (27d5a62
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Related to #1047 (First step of: Make sure async propagation does not block other requests).
The
async
propagation, when executedasync
orsync
when there's no endpoint or an error during its call, always execute the following propagations:items_ancestors
permissions
results
There were tests that checked things like "verify that the
results
propagation has been run but not thepermissions
propagation. Those tests have been updated because it cannot happen anymore.Note: The
groups ancestor
propagation is an exception. It is always executed in sync because there are cases where its results are used in intermediate computations. Since it's very fast compared to the others, it shouldn't be a problem.Review
Easier to review commit by commit as there are a few steps. Details in commit messages.