France-ioi / AlgoreaFrontend

Front-end for the new Algorea platform
MIT License
4 stars 1 forks source link

Feature/join by code approvals #1716

Closed Iloveall closed 3 months ago

Iloveall commented 3 months ago

Description

Fixes #1675

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

...

Test cases

smadbe commented 3 months ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/join-by-code-approvals/playwright-report/index.html

smadbe commented 3 months ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/join-by-code-approvals/playwright-report/index.html

smadbe commented 3 months ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/join-by-code-approvals/playwright-report/index.html

smadbe commented 3 months ago

For this kind of PR where it is useful I fully test the feature and the tests are not trivial, I think it would make sense to give ,in the PR description, a bit of a test scenario (at the least the way to make to the modal) (without covering all scenarios)

smadbe commented 3 months ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/join-by-code-approvals/playwright-report/index.html