France-ioi / AlgoreaFrontend

Front-end for the new Algorea platform
MIT License
4 stars 1 forks source link

Feature/group header sub title #1794

Closed Iloveall closed 6 days ago

Iloveall commented 1 week ago

Description

Fixes #1788

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

I've created createGroup, deleteGroup fixtures and can be reusable for other tests. It works in test context, also it possible to put it on worker level, but seems all our tests written in test context with test steps.

I've tried to create as before/after each test fixture (and so no need to define it in before/each inside each file), but then problem is - difficult to define needed user (usual, demo) or we can wrap fixture by functions and pass needed function as param. So for now need to define user in before each test

When test failed, delete group fixture will delete group - that's good. But not sure about when tests are breaks by another commit has pushed.

Also there is case when delete group is failed and the test group is left. For now I have only idea to create one more test for check and cleanup test groups are left as they have common pattern ex. E2E-1727444716909

Test cases

  1. Given I am the usual user
  2. When I go to a time-limited page
  3. Then I add associated activity and click on "Save"
  4. Then I see subtitle
smadbe commented 1 week ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/group-header-sub-title/playwright-report/index.html

smadbe commented 1 week ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/group-header-sub-title/playwright-report/index.html

smadbe commented 1 week ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/group-header-sub-title/playwright-report/index.html

smadbe commented 6 days ago

Also there is case when delete group is failed and the test group is left. For now I have only idea to create one more test for check and cleanup test groups are left as they have common pattern ex. E2E-1727444716909

Looks good, the problem is that you need to make sure you do not delete the groups which are tested currently by another process. Possibly you have to start the group id by a date (eg. E2E-240930-44716909) and do not delete those with the date of today.

smadbe commented 6 days ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/group-header-sub-title/playwright-report/index.html

smadbe commented 6 days ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/group-header-sub-title/playwright-report/index.html