Adds quick grant view content

France-ioi / AlgoreaFrontend

Front-end for the new Algorea platform

MIT License

4 stars 1 forks source link

Adds quick grant view content #1808

Closed Iloveall closed 2 weeks ago

Iloveall commented 1 month ago

Description

Fixes #1790

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

During development I've faced randomly 400 error when created the item, so It could be potentially reason of failed tests

{ "success": false, "message": "Bad Request", "error_text": "EOF" }

Test cases

Branch for test

smadbe commented 1 month ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/quick-add-perm-button/playwright-report/index.html

smadbe commented 1 month ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/quick-add-perm-button/playwright-report/index.html

smadbe commented 1 month ago

I feel it is not very clear it is not a button and not just a badge... Do you have idea how we could improve that? Maybe already by adding a "+" icon on the left? Also, probably the button should be in orange probably, don't you think?

smadbe commented 1 month ago

Also the "can view" on hover is weird

Iloveall commented 1 month ago

As discussed on Slack:

remove the tooltip/title on the row which displays "can view" on hover

make the border color a bit darker on hover

I've fix case with border color;
For tooltip case I've created issue as it requires to do changes in other files that not related to current issue https://github.com/France-ioi/AlgoreaFrontend/issues/1820

smadbe commented 2 weeks ago

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/quick-add-perm-button/playwright-report/index.html