Francesco149 / koohii

osu! pp and difficulty calculator, pure java implementation of https://github.com/Francesco149/oppai-ng
The Unlicense
12 stars 1 forks source link

beatmap 1231758: java.lang.NumberFormatException: For input string: "SliderBorder:BMAPI.Colour" #6

Closed Tillerino closed 6 years ago

Tillerino commented 6 years ago

Something isn't working with beatmap 1231758. Any ideas?

java.lang.NumberFormatException: For input string: "SliderBorder:BMAPI.Colour"
        at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043)
        at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
        at java.lang.Double.parseDouble(Double.java:538)
        at com.github.francesco149.koohii.Koohii$Parser.timing(Koohii.java:498)
        at com.github.francesco149.koohii.Koohii$Parser.map(Koohii.java:592)
omkelderman commented 6 years ago

ok wtf ppy plz... wtf

Francesco149 commented 6 years ago

lol what ????? guess we'll have to swallow invalid lines

omkelderman commented 6 years ago

note that as I discovered in Francesco149/oppai-ng#29 invalid lines in HitObjects section do fail to load in the osu client and thus maybe should fail here as well 🤔 (unless you dont care about swallowing more bullshit than peppy does)

Francesco149 commented 6 years ago

since we keep getting evidence that there is nothing to trust about .osu files in the wild i'd rather just swallow all invalid lines and hope for the best