search

Francesco149 / ojsama

pure javascript implementation of https://github.com/Francesco149/oppai-ng
The Unlicense
26 stars 7 forks source link

Calculated pp isn't the same as real pp #29

Open Eliteronix opened 3 years ago

Eliteronix commented 3 years ago

I've used a couple of scores for testing but the ppv2 function always seems to be about 20pp off.

In this example I've used this score: https://osu.ppy.sh/scores/osu/3092733019

And this is the code I am using (data comes from osu! api with node-osu npm package): image

I've added a some logging for easy comparison of the values: image

I am inputting the map data from the api instead of parsing a .osu file but judging from the code in the repository it shouldn't make a difference if I didn't miss anything. Could this maybe just be an issue due to the recent performance recalculations that still need to be adapted or is this maybe just a mistake from my side?

Francesco149 commented 3 years ago

the newest changes are not implemented, so thats probably why

also, it's not supposed to be 1:1 accurate. it doesn't handle slider calculations because they significantly slow down calc and add too much code

Eliteronix commented 3 years ago

Thanks for the quick answer. I'll wait for the changes then and check again just in case.