Francesco149 / oppai-ng

difficulty and pp calculator for osu!. better, smaller, faster rewrite of https://github.com/Francesco149/oppai
The Unlicense
156 stars 36 forks source link

incorrect max combo on https://osu.ppy.sh/b/67079 #22

Closed Francesco149 closed 6 years ago

Francesco149 commented 6 years ago

https://osu.ppy.sh/b/67079

480 instead of 469

Francesco149 commented 6 years ago

this must be some kind of quirk with old maps.

at 280+ combo (00:53:016 (1) - ) in editor you can see ticks in the middle of the sliders, but if you play the map they aren't there and don't count towards combo

?????????????

Francesco149 commented 6 years ago

if i export the map as format v14 the ticks display, but if i change it back to v7 they disappear

Francesco149 commented 6 years ago

the treshold seems to be that on beatmap <= v7 if a slider only has 1 tick and it's more than halfway into the slider it's ignored, testing....

Francesco149 commented 6 years ago

or maybe it's just that the old maps don't apply bpm multiplier to slider ticks?

Francesco149 commented 6 years ago

yeah it's the same quirk that i had in taiko already