search

Francesco149 / oppai-ng

difficulty and pp calculator for osu!. better, smaller, faster rewrite of https://github.com/Francesco149/oppai
The Unlicense
155 stars 36 forks source link

shared library build #36

Closed Francesco149 closed 5 years ago

Francesco149 commented 6 years ago

since projects such as the live pp counter are compiling oppai to a shared library I'd like to have an upstream build so they don't have to fork it.

this was attempted before by https://github.com/Francesco149/oppai-ng/pull/8

but it needs to work on both windows and *nix and no makefile

should be as easy as defining some OPPAIAPI macro to __declspec(dllexport) on windows and nothing on *nix and giving it to all interface functions and adding a flag to the build scripts for shared lib mode

maybe even make it so you can compile as a static lib

Francesco149 commented 5 years ago

this is almost working. already tested on linux, windows build needs to be fixed so i gotta boot into windows, fix the libbuild.bat and test it

Francesco149 commented 5 years ago

so the windows shared library build works fine but appveryor can't build it????

it just seems to try and call lib with invalid arguments, must be something appveryor's msvc is missing https://ci.appveyor.com/project/Francesco149/oppai-ng/builds/20211615#L159

Francesco149 commented 5 years ago

ok so im stupid, there's a random lib call after libbuild.bat in release.ps1, i have no idea how that ended up there