search

Francesco149 / oppai-ng

difficulty and pp calculator for osu!. better, smaller, faster rewrite of https://github.com/Francesco149/oppai
The Unlicense
155 stars 36 forks source link

2018-2019 pp changes #40

Closed Francesco149 closed 5 years ago

Francesco149 commented 5 years ago

don't merge until we have official data for the test suite

Francesco149 commented 5 years ago

gonna use this branch for all the pp changes, WIP...

Francesco149 commented 5 years ago

weird, if i remove the angle bonus from speed pp it matches smoogi's xexxar-all site pretty closely, but with the angle bonus in speed pp it gives way too big values. guess i'll wait, maybe xexxar-all isn't updated

Francesco149 commented 5 years ago

it might also be that due to the lack of slider calculations, the angle value is off enough to mess it up, will try to approximate slider tail

Francesco149 commented 5 years ago

seems closer now, will still try approximating slider tails though

Francesco149 commented 5 years ago

nevermind i fixed it, now it matches smoogi's site closely B)

Francesco149 commented 5 years ago

note to self: squash all commits after https://github.com/Francesco149/oppai-ng/pull/40/commits/4f375ab5d00d644dba29a5deced8be2cad30f16a before merging

Francesco149 commented 5 years ago

need to add this https://github.com/ppy/osu-performance/commit/2f0fc7b1fa84dfe07e3f475e38dd3bf83fe92193

Francesco149 commented 5 years ago

also need to check if the latest commits here affect anything https://github.com/ppy/osu/pull/3839

Francesco149 commented 5 years ago

need to add this ppy/osu-performance@2f0fc7b

now that I look at it more closely it seems to be just a refactor and effectively does nothing

Francesco149 commented 5 years ago

also need to check if the latest commits here affect anything ppy/osu#3839

seems like it's just refactoring, guess ill start porting this to other versions of oppai

Francesco149 commented 5 years ago

cleaned up commit history

MaxKruse commented 5 years ago

Dad pp is finalized, pls push :*

Francesco149 commented 5 years ago

cant yet because not all scores are recalculated (for example freedom dive is still 820)

Francesco149 commented 5 years ago

sooo defenders is quite a bit off, ill see if i can improve it before merging

Francesco149 commented 5 years ago

ooooh the high CS bonus was completely wrong, now it's close :ok_hand:

Francesco149 commented 5 years ago

average error is 1.1%, worst error is 5.9% on death dance due to missing slider calcs. most maps arent that bad though, pretty happy with it

MaxKruse commented 5 years ago

rip fopen()