search

Francesco149 / oppai-ng

difficulty and pp calculator for osu!. better, smaller, faster rewrite of https://github.com/Francesco149/oppai
The Unlicense
155 stars 36 forks source link

Invalid initial strain interval end, Lost peak strain for only/last section #45

Closed McKay42 closed 5 years ago

McKay42 commented 5 years ago

See https://github.com/ppy/osu/blob/master/osu.Game.Rulesets.Osu/Difficulty/OsuDifficultyCalculator.cs

To test this, simply create a beatmap which only contains circles with the same time (and nothing else). osu! will return valid stars (e.g. 3.84), but oppai will return 0 stars.

The initial interval_end value change is mostly to stay 1:1 with osu code, the effect should be negligible.

Francesco149 commented 5 years ago 
avg err 0.003295
max err 0.018298 on 827015

huh, somehow this makes it way more accurate? very interesting, maybe now i can lower the test suite threshold back to 2%