search

Francesco149 / oppai-ng

difficulty and pp calculator for osu!. better, smaller, faster rewrite of https://github.com/Francesco149/oppai
The Unlicense
156 stars 36 forks source link

Infinity pp for Ranked Map #51

Open instr3 opened 5 years ago

instr3 commented 5 years ago

The map is https://osu.ppy.sh/beatmapsets/91353#osu/285777 (easy) Reference star difficulty: 1.34 Oppai's output:

Baek Ji-young - After a Long Time (氚膘鞓?- 頃滌案 歆€雮橃劀) [scanter's Easy] mapped by Sonnyc

AR3 OD2 CS3 HP2
300 hitwindow: 68 ms
18 circles, 27 sliders, 2 spinners
1.25799e+14 stars (8.38656e+13 aim, 1.64094e+09 speed)

speed strain:                                              ^
  aim strain:                                              ^

100/100x 100%
inf pp (inf aim, 1.69152e+28 speed, 1.96 acc)

Also thanks to @jxpxxzj

Syriiin commented 4 years ago

this is caused by the beatmap file not following the correct format.

at the end of the [HitObjects] section there are 2 sliders that are out of order

image

fixing the beatmap file fixes the problem

image

presumably this happens because oppai doesn't sort the hitobjects (since they are supposed to already be sorted) and falls into some sort of miscalculation when calculating strains (maybe?)

whatever the reason, this can be fixed by simply sorting the objects after parsing them